Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-592: Adding lucene examples to auth0 users search #912

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Nov 13, 2023

🔧 Changes

Adding example lucene queries to the auth0 users search command. Some examples did exist as help text, but this change makes them even more visible. I selected this example somewhat arbitrarily but it seemed to cover several fields, parentheses, wildcard operator and logistcal AND/OR.

Screenshot 2023-11-13 at 3 52 41 PM

📚 References

🔬 Testing

No functional changes.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner November 13, 2023 21:00
@willvedd willvedd changed the title DXCDT-592: Adding lucene examples to DXCDT-592: Adding lucene examples to auth0 users search Nov 13, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5b138a) 72.59% compared to head (bb85f95) 72.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files          93       93           
  Lines       12393    12393           
=======================================
  Hits         8997     8997           
  Misses       2874     2874           
  Partials      522      522           
Files Coverage Δ
internal/cli/users.go 74.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit pick, otherwise looks good.

internal/cli/users.go Outdated Show resolved Hide resolved
@willvedd willvedd enabled auto-merge (squash) November 14, 2023 15:31
@willvedd willvedd merged commit 0910c2a into main Nov 14, 2023
6 checks passed
@willvedd willvedd deleted the DXCDT-592-auth0-users-search-help-text branch November 14, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants