Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Import operation emailProvider and custom email provider action in the same execution #1005

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix: Import operation emailProvider and custom email provider action in the same execution #1005

merged 1 commit into from
Dec 18, 2024

Conversation

kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Dec 18, 2024 •
edited
Loading

🔧 Changes

Fix Import when processing the type emailProvider and creating a custom email provider action in the same execution

📚 References

#950

🔬 Testing

Test passed

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@kushalshit27
Fix:
c85cbac 
Adjust order of processChanges to ensure that
actions are created before email provider is
updated
@kushalshit27 kushalshit27 changed the title Fix: Import emailProvider and custom email provider action in the same execution Fix: Import operation emailProvider and custom email provider action in the same execution Dec 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (4fc072b) to head (c85cbac).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   80.37%   80.37%           
=======================================
  Files         125      125           
  Lines        4545     4546    +1     
  Branches      876      876           
=======================================
+ Hits         3653     3654    +1     
  Misses        528      528           
  Partials      364      364

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalshit27 kushalshit27 marked this pull request as ready for review December 18, 2024 08:45
@kushalshit27 kushalshit27 requested a review from a team as a code owner December 18, 2024 08:45
@kushalshit27 kushalshit27 merged commit 998fba2 into master Dec 18, 2024
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-747-fix-deploy-custom-email-provider branch December 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandan-bhat nandan-bhat nandan-bhat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushalshit27 @codecov-commenter @nandan-bhat