Enabling keyword preservation for wider array of resources #864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As noted by #845 , the guardian set of resources are not having their correlating keywords preserved.
The issue here is that these resources leverage the
name
property as the primary identifier. However, the existing logic for keyword preservation does not allow for this identifier to be used; this is a bug. The solution, courtesy of @brendenpalmer is to support all identifiers but only use the ones that correlate to an existing field.This change enables keyword preservation for a wider array of resources that were previously in a broken state.
📚 References
guardianFactorProviders
#845🔬 Testing
Added a couple new unit test cases to the main keyword preservation test. These demonstrate that the
guardianFactorProviders
andpages
resources are working as expected.📝 Checklist