Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ULX-1596] feat: add custom prompts partials #886

Closed
wants to merge 1 commit into from

Conversation

joel-hamilton
Copy link

@joel-hamilton joel-hamilton commented Jan 31, 2024

🔧 Changes

  • This PR adds support for importing/exporting custom prompts partials (feature docs). This feature allows customers to add HTML/Liquid to various extensibility points in the Login/Signup prompts.
  • We add a new prompts/partials.json config, and a partials directory for the actual partials (see example below)

Note:

  • we should consider implementing a flat structure and just naming our templates {prompt}/{screen}/{insertion_point}.liquid
  • otherwise, we'll need to add another layer of directory nesting to capture the screen (the one below is missing a subdirectory for login and for signup
    image

📚 References

ULX-1596

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ifyoumakeit
Copy link

Hi! Is there any update on when this will be part of the CLI?

@rickode1
Copy link

Hi! Is there any update on when this will be part of the CLI?

+1

@developerkunal
Copy link
Contributor

Hi @ifyoumakeit & @xkabr00,

We have already released this feature, so please take a look and test it.

@joel-hamilton, thank you for your contribution. I have created another PR and released it, so I will be closing this PR in reference to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants