Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering the prompt-screen's settings - EA #998

Merged

Conversation

ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Dec 6, 2024

🔧 Changes

Add support for rendering the prompt-screen's settings

prompts:
  screenRenderers:
    - signup-id:
        signup-id: ./prompts/renderSettings/signup-id_signup-id.json
    - signup-password:
        signup-password: ./prompts/renderSettings/signup-password_signup-password.json
    - login:
        login: ./prompts/renderSettings/login_login.json
    - login-id:
        login-id: ./prompts/renderSettings/login-id_login-id.json
    - login-password:
        login-password: ./prompts/renderSettings/login-password_login-password.json
    - login-passwordless:
        login-passwordless-email-code: >-
          ./prompts/renderSettings/login-passwordless_login-passwordless-email-code.json
        login-passwordless-sms-otp: >-
          ./prompts/renderSettings/login-passwordless_login-passwordless-sms-otp.json

⚙️ Configuration options:

  "AUTH0_INCLUDED_ONLY": ["prompts"]

📚 References

https://auth0.com/docs/customize/login-pages/advanced-customizations/getting-started/configure-acul-screens

📌 Note:

🔬 Testing

  • unit test added for rendering the prompt-screen's settings
  • E2E test updated

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ramya18101 ramya18101 requested a review from a team as a code owner December 6, 2024 13:23
@kushalshit27 kushalshit27 marked this pull request as draft December 7, 2024 02:36
Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for :

  • directory/handlers/prompts.ts
  • yaml/handlers/prompts.ts

@kushalshit27
Copy link
Contributor

Please update PR description.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.97297% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (04c5b05) to head (ac99156).

Files with missing lines Patch % Lines
src/context/directory/handlers/prompts.ts 28.57% 13 Missing and 2 partials ⚠️
src/tools/auth0/handlers/prompts.ts 78.04% 6 Missing and 3 partials ⚠️
src/context/yaml/handlers/prompts.ts 89.58% 3 Missing and 2 partials ⚠️
src/tools/auth0/handlers/triggers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   80.24%   80.04%   -0.21%     
==========================================
  Files         125      125              
  Lines        4435     4540     +105     
  Branches      863      875      +12     
==========================================
+ Hits         3559     3634      +75     
- Misses        519      541      +22     
- Partials      357      365       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalshit27 kushalshit27 marked this pull request as ready for review December 9, 2024 12:56
@kushalshit27 kushalshit27 merged commit 66f0b01 into master Dec 9, 2024
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-662-deployCli-support-for-prompt-screen-settings branch December 9, 2024 13:30
@kushalshit27 kushalshit27 changed the title Add support for rendering the prompt-screen's settings Add support for rendering the prompt-screen's settings - EA Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants