Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of Android example app on Mac ARM #333

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 2, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR fixes a couple of errors preventing the build of the Android example app on Mac M2 processors.

Screenshot 2023-11-02 at 23 21 54 Screenshot 2023-11-02 at 23 20 08

@Widcket Widcket added the review:tiny Tiny review label Nov 2, 2023
@Widcket Widcket requested a review from a team as a code owner November 2, 2023 23:25
@Widcket Widcket temporarily deployed to internal November 2, 2023 23:26 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal November 2, 2023 23:26 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal November 2, 2023 23:26 — with GitHub Actions Inactive
@@ -28,7 +28,6 @@ apply plugin: 'jacoco'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
namespace exampleAppApplicationId
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was duplicated; see L32 below if (project.android.hasProperty("namespace")).

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253209a) 96.08% compared to head (dc85834) 95.80%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #333      +/-   ##
============================================
- Coverage     96.08%   95.80%   -0.29%     
============================================
  Files            97       76      -21     
  Lines          1611     1121     -490     
  Branches        331      281      -50     
============================================
- Hits           1548     1074     -474     
+ Misses           49       46       -3     
+ Partials         14        1      -13     
Flag Coverage Δ
auth0_flutter 100.00% <100.00%> (ø)
auth0_flutter_android ?
auth0_flutter_ios ?
auth0_flutter_platform_interface 87.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lib/src/web/extensions/user_profile_extension.dart 100.00% <100.00%> (ø)
...lutter_platform_interface/lib/src/credentials.dart 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket changed the title Fix example app build on Mac ARM Fix build of Android example app on Mac ARM Nov 3, 2023
@Widcket Widcket merged commit 0e1c23f into main Nov 6, 2023
17 checks passed
@Widcket Widcket deleted the chore/example-app-arm-build branch November 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants