Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing parameters onLoad #363

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Dec 6, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Adds support for passing custom parameters to onLoad, which are used as global custom parameters in the underlying Auth0-SPA-JS SDK.

📎 References

Closes #345

🎯 Testing

Update the sample application here:

auth0Web.onLoad(parameters: {'foo': 'bar'}).then((final credentials) => setState(() {
  _output = credentials?.idToken ?? '';
  _isLoggedIn = credentials != null;
}));

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253209a) 96.08% compared to head (cc8b662) 96.31%.
Report is 29 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #363      +/-   ##
============================================
+ Coverage     96.08%   96.31%   +0.22%     
============================================
  Files            97       98       +1     
  Lines          1611     1573      -38     
  Branches        331      328       -3     
============================================
- Hits           1548     1515      -33     
- Misses           49       50       +1     
+ Partials         14        8       -6     
Flag Coverage Δ
auth0_flutter 100.00% <100.00%> (ø)
auth0_flutter_android 97.35% <ø> (+0.79%) ⬆️
auth0_flutter_ios 99.84% <ø> (ø)
auth0_flutter_platform_interface 87.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frederikprijck
Copy link
Member Author

Needs #364 to fix the CI.

@frederikprijck frederikprijck merged commit 8a7aa05 into main Dec 6, 2023
13 of 14 checks passed
@frederikprijck frederikprijck deleted the feat/params-onload branch December 6, 2023 13:38
This was referenced Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "parameters" field in onLoad method of Auth0Web
2 participants