-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing parameters onLoad #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
temporarily deployed
to
internal
December 6, 2023 09:31 — with
GitHub Actions
Inactive
frederikprijck
temporarily deployed
to
internal
December 6, 2023 09:31 — with
GitHub Actions
Inactive
frederikprijck
temporarily deployed
to
internal
December 6, 2023 09:31 — with
GitHub Actions
Inactive
frederikprijck
temporarily deployed
to
internal
December 6, 2023 09:31 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
============================================
+ Coverage 96.08% 96.31% +0.22%
============================================
Files 97 98 +1
Lines 1611 1573 -38
Branches 331 328 -3
============================================
- Hits 1548 1515 -33
- Misses 49 50 +1
+ Partials 14 8 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Needs #364 to fix the CI. |
Widcket
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Adds support for passing custom parameters to onLoad, which are used as global custom parameters in the underlying Auth0-SPA-JS SDK.
📎 References
Closes #345
🎯 Testing
Update the sample application here: