Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

af: Install Kover from the library's Gradle config #372

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 7, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR makes sure the Kover Gradle plugin is properly installed on the library's Gradle config. Previously, it was installed on the example app's config and applied on the library's config. When installed on another app, it couldn't find the plugin.

📎 References

Fixes #369

🎯 Testing

This was tested manually on the Quickstart sample app.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253209a) 96.08% compared to head (8795285) 96.31%.
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #372      +/-   ##
============================================
+ Coverage     96.08%   96.31%   +0.22%     
============================================
  Files            97       98       +1     
  Lines          1611     1573      -38     
  Branches        331      328       -3     
============================================
- Hits           1548     1515      -33     
- Misses           49       50       +1     
+ Partials         14        8       -6     
Flag Coverage Δ
auth0_flutter 100.00% <100.00%> (ø)
auth0_flutter_android 97.35% <ø> (+0.79%) ⬆️
auth0_flutter_ios 99.84% <ø> (ø)
auth0_flutter_platform_interface 87.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket changed the title Install Kover from the library's Gradle config af: Install Kover from the library's Gradle config Dec 7, 2023
@Widcket Widcket merged commit 8a03210 into main Dec 7, 2023
15 of 16 checks passed
@Widcket Widcket deleted the fix/kover-plugin branch December 7, 2023 11:20
@Widcket Widcket mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in upgrade version 1.4.0
2 participants