-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-4670] Improved state handling errors #140
Conversation
Failures look OK. Just a dupe Snyk webhook causing that one failure; fixed that. And Codecov is weird, as usual. |
Codecov was failing because there was a check in @evansims I see the |
Changes
This PR provides additional information to the error message received when a state validation error occurs. To minimize any potential breaking changes, it:
Note that the SDK currently needs to support the deprecated methods that use the session for auth state param storage (both for building the auth URL as well as processing the callback). In v2, we should:
Note that this change also includes additional tests for functionality that was not changed, in addition to tests for the changes. The first commit adds tests to cover all paths prior to the change, as well as updates tests to the new expected behavor. This commit provides the functional change.