Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated release workflow #313

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Add automated release workflow #313

merged 8 commits into from
Dec 20, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Dec 20, 2023 •
edited
Loading

Changes

This adds the automated release workflow based on what we have in other .NET repositories.
The main difference here is that this repository is a mono-repository, publishing multiple packages.

Therefore, our nuget-release workflow and nuget-publish action are different from the other .NET repositories.

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner December 20, 2023 12:22
@frederikprijck frederikprijck marked this pull request as draft December 20, 2023 12:49
@frederikprijck frederikprijck marked this pull request as ready for review December 20, 2023 15:21
ewanharris
ewanharris requested changes Dec 20, 2023
View reviewed changes
.github/actions/nuget-release/action.yml Outdated
with:
token: ${{ inputs.github-token }}
name: ${{ steps.get_version.outputs.version }}
# body: ${{ steps.get_release_notes.outputs.release-notes }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this and the get-release-notes step for now?

Copy link
Member Author

@frederikprijck frederikprijck Dec 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, we should keep it (well uncomment it) !

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/nuget-release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@frederikprijck frederikprijck enabled auto-merge (squash) December 20, 2023 15:48
@frederikprijck frederikprijck merged commit c0caa42 into master Dec 20, 2023
4 checks passed
@frederikprijck frederikprijck deleted the feat/automated-release branch December 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikprijck @ewanharris