Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net-6.0 target to Auth0 MAUI NuGet package #324

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

kmoo
Copy link
Contributor

@kmoo kmoo commented Apr 24, 2024

Changes

  • Add net-6.0 target to Auth0 MAUI NuGet package, to allow MAUI apps with unit tests (using .net-8 and above targets) to use this package.

References

Please include relevant links supporting this change such as a:

  • Support ticket: 02347957

Checklist

@kmoo kmoo marked this pull request as ready for review April 24, 2024 18:30
@kmoo kmoo requested a review from a team as a code owner April 24, 2024 18:30
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

Can you revert the version changes, as we cut releases separately from merging changes.

@kmoo
Copy link
Contributor Author

kmoo commented Apr 24, 2024

Thanks, @frederikprijck!

@kmoo kmoo requested a review from frederikprijck April 24, 2024 18:58
@frederikprijck
Copy link
Member

Thanks for the PR, apologies we missed the Nuget Target for .NET 6.0 (we do target it in the csproj, but that isnt enough) 😞

@frederikprijck frederikprijck enabled auto-merge (squash) April 24, 2024 19:13
@frederikprijck
Copy link
Member

Looks like we need #325 first.

@frederikprijck
Copy link
Member

Apologies for the delay. Battling some CI issues that I need to figure out on the other PR first.

@frederikprijck
Copy link
Member

Can you merge in master ? 🙏

@frederikprijck frederikprijck disabled auto-merge April 26, 2024 08:50
@kmoo kmoo force-pushed the add-net-6.0-target branch from 48ca01a to 48627f0 Compare April 26, 2024 14:48
@kmoo kmoo deployed to external April 26, 2024 14:48 — with GitHub Actions Active
@kmoo
Copy link
Contributor Author

kmoo commented Apr 26, 2024

Sure thing! Thanks, @frederikprijck

@frederikprijck frederikprijck enabled auto-merge (squash) April 29, 2024 07:21
@frederikprijck frederikprijck merged commit 26a3485 into auth0:master Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants