Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure external_id is defined as string instead of int #679

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Nov 28, 2023

Changes

external_id should be a string, not an int.

References

https://auth0.com/docs/manage-users/user-migration/bulk-user-imports#request-bulk-user-import

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@frederikprijck frederikprijck merged commit 2b4f1d6 into master Nov 28, 2023
8 checks passed
@frederikprijck frederikprijck deleted the fix/external-id branch November 28, 2023 13:15
@frederikprijck frederikprijck mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants