Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CnameApiKey to CustomDomainVerificationResponse (#757) #758

Closed
wants to merge 9 commits into from

Conversation

tmschlot
Copy link
Contributor

@tmschlot tmschlot commented Jan 2, 2025

Changes

Please describe both what is changing and why this is important.

  • Added CnameApiKey property to CustomDomainVerificationResponse class to support self-managed certificates

References

Testing

Custom domain tests are limited, as described by the existing tests, which must be run manually. Since no other tests exist to test rudimentary serialization, no tests were added.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@tmschlot tmschlot requested a review from a team as a code owner January 2, 2025 20:37
@kailash-b kailash-b self-assigned this Jan 9, 2025
@kailash-b
Copy link
Contributor

Hi @tmschlot
Thanks for the contribution.
While the changes look good, we can only merge signed commits.

Can you please sign your commit?
You could follow the instructions here

Apologies for this last minute ask, this has been a recent change and we are updating our ReadMe (contribution guidelines) to include this pre-requisite.

@tmschlot
Copy link
Contributor Author

tmschlot commented Jan 9, 2025

@kailash-b... I tried and finally was able to get some correctly signed commits pushed, but I'm afraid I may have screwed up the graph in the process. Let me know if you'd prefer me to close this PR and create a new one with a cleaner graph or if you've got the knowledge/ability to clean this up before merging.

@kailash-b
Copy link
Contributor

@tmschlot - It'd be great if you can close this PR and raise a separate one on the latest - I think it'd be easier than cleaning up this commit graph.

@tmschlot tmschlot closed this Jan 10, 2025
@tmschlot tmschlot deleted the cname_api_key branch January 10, 2025 14:01
@tmschlot
Copy link
Contributor Author

Created #764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants