-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds CnameApiKey to CustomDomainVerificationResponse (#757) #758
Conversation
Hi @tmschlot Can you please sign your commit? Apologies for this last minute ask, this has been a recent change and we are updating our ReadMe (contribution guidelines) to include this pre-requisite. |
…into cname_api_key
…into cname_api_key
@kailash-b... I tried and finally was able to get some correctly signed commits pushed, but I'm afraid I may have screwed up the graph in the process. Let me know if you'd prefer me to close this PR and create a new one with a cleaner graph or if you've got the knowledge/ability to clean this up before merging. |
@tmschlot - It'd be great if you can close this PR and raise a separate one on the latest - I think it'd be easier than cleaning up this commit graph. |
Created #764 |
Changes
Please describe both what is changing and why this is important.
CnameApiKey
property toCustomDomainVerificationResponse
class to support self-managed certificatesReferences
Testing
Custom domain tests are limited, as described by the existing tests, which must be run manually. Since no other tests exist to test rudimentary serialization, no tests were added.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors