[SDK-4738] Add support for performing Pushed Authorization Requests #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
force-pushed
the
feat/SDK-4738-par
branch
from
c6fb721 to
93053ce
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 95.10% 95.09% -0.01%
==========================================
Files 46 46
Lines 8939 8984 +45
==========================================
+ Hits 8501 8543 +42
- Misses 334 336 +2
- Partials 104 105 +1 ☔ View full report in Codecov by Sentry. |
Widcket
reviewed
Dec 7, 2023
Widcket
reviewed
Dec 7, 2023
Comment on lines
+425
to
+426
| ResponseType: "code", | ||
| RedirectURI: "http://localhost:3000/callback", |
There was a problem hiding this comment.
Is there any way we can mark these as required?
There was a problem hiding this comment.
I'll add something to the function body to check for the required fields
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Widcket
approved these changes
Dec 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Add support for performing Pushed Authorization Requests using the authentication client provided
📚 References
🔬 Testing
Covered by unit tests and tested manually
📝 Checklist