Type annotations #194
Closed
Type annotations #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanpu
requested changes
Dec 15, 2020
There was a problem hiding this comment.
Hi @CCCodes, thanks for your PR!
I noticed that there are some changes unrelated to type annotations in the PR, would it be possible to only isolate the changes for type annotation as I assume that that is the intent of your PR?
In addition, there are also env/* files as well as pyenv.cfg being committed in this repo, which is not necessary. Could those be removed as well?
After that I will take a close look at the type annotations again. Thanks!
|
Thanks, I made a new pull request with the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185.
Changes proposed in this PR:
Add type annotations for
jobManager.py
jobQueue.py
tangoObjects.py
worker.py
(Branched from tests)
Some type annotations are best guesses because it was hard to determine exactly what types were acceptable. I ran all unittests and new sampleTest on it and got the same results with / and without the annotations, so there were no problems in those cases.