-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtio_fs_nfs_migration_handler: Migration test with handler #4198
base: master
Are you sure you want to change the base?
Conversation
19ee848
to
f12a3fb
Compare
Hi @hellohellenmao , would you please help to review this patch? Thanks. |
@zhencliu we use memory-backend-file on s390x when we use memory-backend with virtio-fs, please reference to the usage of avocado-framework/avocado-vt@85915c0 |
Test log on s390x: RHEL.9: @zhencliu the case LGTM and I'll ack once you update the note in the py file |
cdroms += " virtio" | ||
read_file_cmd = type %s\${test_file} | ||
tail_name = Get-Content | ||
cmd_tail_file = powershell -command "Get-Content %s\${test_file} -wait" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about calling it cmd_wait_file as 'Get-Content' use -wait parameter instead of -tail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reply. Actually 'Get-Content -wait' does mostly like what 'tail -f' does on Linux, so I use cmd_tail_file, to keep consistent for both Linux and Windows
Hit the following error for win2025 guest. 2/2 failed [stderr] Traceback (most recent call last): |
Thanks Xiaoling, it seems it's easy to hit errors when testing on win2025, I will do some tests later, thanks for the verification |
Passed with rhel10 guest, and the log looks good to me. Thanks.
|
edbe8b2
to
1ce0899
Compare
Testing --migration-verify-handles and --migration-confirm-paths over NFS Note we usually use memory-backend-file on s390x for the virtio-fs testing on RHEL, but for the live migration scenario, we have to use memory-backend-memfd due to RHEL-58831. Signed-off-by: Zhenchao Liu <zhencliu@redhat.com>
1ce0899
to
d621b84
Compare
Great, thanks @zhencliu. I might review those patches two or more weeks later as I'm busy on our projects recently. |
Sure. Take your time please, and thank you for your quick response. |
Testing --migration-verify-handles and --migration-confirm-paths over NFS
ID: 2971