-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snp_basic_config: Add snp basic config test case #4224
Conversation
73ba367
to
c184836
Compare
@XueqiangWei @zhencliu @JinLiul Could you please help to review this? |
@zixi-chen Commit signature has been enabled, please repush the pullreq with -S. Thanks. |
Done, thanks. |
Update a retry function to fetch certs from the server. |
@zixi-chen two commits, only one signed, please check it, thanks. |
210e960
to
36fc358
Compare
@zhenchao |
37ed748
to
c54fe62
Compare
7d2c4b3
to
01d25dc
Compare
snp_module_path = "/sys/module/kvm_amd/parameters/sev_snp" | ||
module_status = Y y 1 | ||
snp_guest_check = "journalctl|grep -i -w snp" | ||
guest_tool_install = "dnf install -y snpguest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the snpguest package already been supported in RHEL repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, snpguest package targets 9.6, so don't need to do a workaround here. To run this case, guest image should install snpguest in prior. Thanks.
(1/3) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.snp_basic_config.policy_default.q35: STARTED |
@zixi-chen This case is only for linux, right? If yes, we'd better add "only Linux". |
if int(process.getoutput(socket_count_cmd, shell=True)) != 1: | ||
test.cancel("Host cpu has more than 1 socket, skip the case.") | ||
|
||
vm_name = params["main_vm"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add env_process.preprocess_vm(test, params, env, vm_name) after line 39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Xueqiang, this is discussed with zhenchao, since I don't change configs during the test, the preprocess can be removed since VT will do it by default at the beginning of the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, make sense.
Signed-off-by: Zixi Chen <zixchen@redhat.com>
Signed-off-by: Zixi Chen <zixchen@redhat.com>
@XueqiangWei Updated, tried --guestname=Win11 won't run the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Acked-by: xuwei@redhat.com
ID: 2863