Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor UI changes for streaming with OBS #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pvacey
Copy link

@pvacey pvacey commented Mar 4, 2024

to support streaming this page with OBS to play on spelltable, given that OBS will allow you to block out the hand zone

  • sort the library alphabetically so a player does not see the order of their entire deck when they search it
  • disable card preview when hovering over cards in the hand zone (and exile just to make existing behavior)

@pvacey pvacey changed the title change to search library feature minor UI changes for streaming with OBS Mar 4, 2024
@avocadianmage
Copy link
Owner

Card preview: One of the challenges with disabling card preview for the Hand zone is when you have a lot of cards in your hand and they stack together, making preview necessary. Definitely open to ideas. One potential is a checkbox in the left sidebar that the user can toggle.

If/when that's implemented, don't remove ShowTopOnly, as there shouldn't ever be a case where a zone has that property and needs a preview, since nothing will ever cover the top card in that zone.

Library order: When do you need to open the search bar for the library and not need to shuffle afterward? One nice thing about preserving the card order is for cards like Nissa, Resurgent Animist when you may need to reveal many cards before you get a hit (though interactions like that are currently messy in general with this site).

I am planning to add more robust columns, filtering, and sorting to the dialog which should help with this (e.g., see and sort/filter by mana cost, color, type, etc.) It's a bigger project, but that's next on my todo list (though I wouldn't complain if you want to implement it!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants