[aoc-collector non-root user]: Update vended config #2298
Conversation
| @@ -60,6 +60,7 @@ Resources: | |||
| ContainerDefinitions: | |||
| - Name: aws-collector | |||
| Image: 'public.ecr.aws/aws-observability/aws-otel-collector:latest' | |||
| Privileged: true | |||
There was a problem hiding this comment.
Use user field instead of priveleged to set to the root user.
There was a problem hiding this comment.
I have reverted the changes made to this deployment template as it didn't require root user access. This template is only for instance metrics and not for container/task level metrics and hence don't require root access.
There was a problem hiding this comment.
Where is this template used? Does the config that is passed as a parameter always contain container insights receiver?
There was a problem hiding this comment.
I have reverted the changes made to this deployment template as it didn't require root user access. This template is only for instance metrics and not for container/task level metrics and hence don't require root access.
I think this is a an example template referenced on the ADOT website here. The config of awscontainerinsightreceiver is passed as default but it can be changed through parameters.
I have removed the changes made to ECS deployment template. |
|
This PR is stale because it has been open 30 days with no activity. |
PaurushGarg
force-pushed
the
non-root-user-update-vended-config
branch
from
a03d253 to
dea7575
Compare
Removing changes to ECS deployment template
PaurushGarg
force-pushed
the
non-root-user-update-vended-config
branch
from
dea7575 to
2555c64
Compare
|
Closing this PR as this change has been added to this PR: #2301 |
Description:
Update vended config for
awscontainerinsightreceiverto run Collector withprivilidgedroot-accessDependent on PR: #2297
Link to tracking Issue:
#2222
Testing:
Documentation:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.