feat: Add timeout, retry, and write queue options to AMP remote write exporter #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmorton
commented
Mar 31, 2023
| @@ -9,11 +9,6 @@ clusterName: "" | |||
| additionalLabels: {} | |||
| # app: adot | |||
|
|
|||
| serviceAccount: | |||
There was a problem hiding this comment.
I noticed this value is unused. Let me know if this should be a separate PR.
seanmorton
changed the title
|
This PR is stale because it has been open 60 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add timeout, retry, and write queue options to AMP remote write exporter as defined here. Note that the timeout and retry settings are defined in the shared Exporter Helper.
All default values have been taken from the above linked documentation.
Link to tracking Issue: N/A
Testing: Validate charts script output:
Chart validation /Users/seanmorton/src/pelotech/aws-otel-helm-charts/charts/adot-exporter-for-eks-on-ec2 with Helm v3 PASS - adot-exporter-for-eks-on-ec2/templates/adot-collector/namespace.yaml contains a valid Namespace (amazon-metrics) PASS - adot-exporter-for-eks-on-ec2/templates/adot-collector/serviceaccount.yaml contains a valid ServiceAccount (amazon-metrics.adot-collector-sa) PASS - adot-exporter-for-eks-on-ec2/templates/adot-collector/configmap.yaml contains a valid ConfigMap (amazon-metrics.adot-conf) PASS - adot-exporter-for-eks-on-ec2/templates/adot-collector/clusterrole.yaml contains a valid ClusterRole (adot-collector-role) PASS - adot-exporter-for-eks-on-ec2/templates/adot-collector/clusterrolebinding.yaml contains a valid ClusterRoleBinding (adot-collector-role-binding) PASS - adot-exporter-for-eks-on-ec2/templates/adot-collector/daemonset.yaml contains a valid DaemonSet (amazon-metrics.adot-collector-daemonset) All charts passed validation tests!Documentation: None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.