Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CWAOperator default tolerations and CWA/FluentBit default PriorityClass #137

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

sky333999
Copy link
Contributor

@sky333999 sky333999 commented Dec 17, 2024

Issue #, if available: #54, aws/containers-roadmap#2462

Description of changes:

  • Default tolerations are mainly applicable for daemonsets deployed by the helm-chart / EKS add-on such as CloudWatchAgent and FluentBit. These should not apply to the CloudWatchAgentOperator deployment by default as this impacts scenarios such as a node draining.
  • feat(fluent-bit): set system-node-critical as a default priorityClass #70 introduced the ability to set the PriorityClass for the CloudWatchAgent and the FluentBit daemonsets, but set the default to "". Given observability agents are critical to the health of a cluster, this change updates these to run as "system-node-critical" by default.

Both of these changes will be included in the next major version bump of the helm-chart / EKS add-on.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…riority class name to system-node-critical for CWA and FluentBit
@sky333999 sky333999 merged commit 2d9451c into main Dec 17, 2024
3 checks passed
@sky333999 sky333999 deleted the sky333999/tolerations-priority branch December 17, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants