Adding support for p5.48xlarge and p4de.24xlarge instance types and Fix for FsX monitoring #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New GPU instance types added to the AWS instance family
With the new releases, the chef-dna file has modified the key for FsX ID. Now it is set to fsx_fs_ids, instead of cfn_fsx_fs_id. Due to this FsX metrics were not captured on the dashboard. This update should fix it.
gallanik
changed the title
nicolaven
approved these changes
Jan 15, 2024
nicolaven
approved these changes
Jan 15, 2024
Fixing repo name in the monitoring_url variable
@nicolaven - AWS has released new instance types and when I installed this tool, it did not pick up the p5 instances. Hence the need to include them. |
sean-smith
reviewed
Jan 16, 2024
| @@ -14,7 +14,7 @@ monitoring_dir_name=aws-parallelcluster-monitoring | |||
| monitoring_tarball="${monitoring_dir_name}.tar.gz" | |||
|
|
|||
| #get GitHub repo to clone and the installation script | |||
| monitoring_url=https://github.com/aws-samples/aws-parallelcluster-monitoring/archive/refs/tags/${version}.tar.gz | |||
| monitoring_url=https://github.com/gallanik/aws-parallelcluster-monitoring/archive/refs/tags/${version}.tar.gz | |||
|
We can't merge this with your branch. Please change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New GPU instance types added to the AWS instance family
Issue #, if available:
Description of changes:
Modified prometheus/prometheus.yml to add p4de.24xlarge and p5.48xlarge. These are new GPU instance types released by AWS.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.