Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Java and Gradle version in Android sample #34

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yq-yang-qin
Copy link
Collaborator

Description

  • Bump Java and Gradle version in Android sample

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

@zxkane zxkane requested a review from zhu-xiaowei December 14, 2024 15:13
@zhu-xiaowei
Copy link
Contributor

For build-android actions, Please fix the build error:

error: invalid source release: 21

For the build-ios actions, Please update the runs-on parameter in
https://github.com/aws-samples/swift-chat/actions/runs/12339018149/workflow#L11,
https://github.com/aws-samples/clickstream-sdk-samples/blob/main/.github/workflows/build-rn.yml#L37
to macos-latest and try again.

@yq-yang-qin yq-yang-qin changed the title Bump Java and Gradle version in Android sample chore: bump Java and Gradle version in Android sample Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants