Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command packages. #224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

commiterate
Copy link

@commiterate commiterate commented Dec 16, 2024

Issue #, if available: N/A

Description of changes: Fix command packages.

Go by default will name commands after their package name. Switching to use this convention (also used by other AWS Go packages like amazon-ssm-agent and amazon-cloudwatch-agent).

For example, suppose the file layout is like this:

amazon-ec2-metadata-mock/
└── cmd/
    ├── ec2-metadata-mock/
    │   └── main.go
    └── ec2-metadata-mock-debug/
        └── main.go

Running go build -o build/ ./cmd/... will create this:

amazon-ec2-metadata-mock/
└── build/
    ├── ec2-metadata-mock
    └── ec2-metadata-mock-debug

Related: NixOS/nixpkgs#365690 (comment)

Please create a v1.13.0 release after this is merged.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Jan 2, 2025

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jan 2, 2025
@commiterate
Copy link
Author

Not stale.

@github-actions github-actions bot removed the stale Issues / PRs with no activity label Jan 3, 2025
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jan 19, 2025
@commiterate
Copy link
Author

Not stale.

@github-actions github-actions bot removed the stale Issues / PRs with no activity label Jan 20, 2025
@commiterate
Copy link
Author

@Lu-David Anything else needed from me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant