Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EKS Service for the Beta Endpoint. #3143

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

orsenthil
Copy link
Member

The DescribeCluster against the Beta endpoint cluster was failing with operation error STS: AssumeRoleWithWebIdentity

For the tests we exercise against a custom endpoint, for EKS we need to send the PartitionID, and SigningRegion, so that STS can use those to sign the request for the EKS cluster with the custom endpoint.

Testing Done

  • Locally was able to describe cluster against a custom endpoint.
  • Tested in internal CI.

@orsenthil orsenthil requested a review from a team as a code owner December 10, 2024 03:43
Copy link
Contributor

@sushrk sushrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@orsenthil orsenthil merged commit 5bcc561 into aws:master Dec 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants