fix(lambda): deployment failure when layers are added to container functions #15037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nija-at
changed the title
nija-at
previously requested changes
Jun 10, 2021
There was a problem hiding this comment.
Hi @mprencipe - Thanks for submitting this PR.
See my comment below.
| @@ -65,5 +65,8 @@ export class DockerImageFunction extends Function { | |||
| runtime: Runtime.FROM_IMAGE, | |||
| code: props.code._bind(), | |||
| }); | |||
| if (props.layers) { | |||
There was a problem hiding this comment.
Would be better to move this into Function instead. Check that the runtime is FROM_IMAGE and fail if a layer is specified.
nija-at
approved these changes
Jun 10, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #14143 by throwing an error during synthesis if layers are used in a container function.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license