-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fsx): specify file system type version for the Lustre file system #31136
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
22f4228
validate
badmintoncryer d4fd1c9
add integ test
badmintoncryer 2c51c2f
add unit test
badmintoncryer e761741
chore
badmintoncryer 531e6de
chore
badmintoncryer 5ff5f18
add readme
badmintoncryer 1f4deec
Merge branch 'main' into 31130-luster
badmintoncryer 3a75639
update readme
badmintoncryer 1faa73f
Merge branch 'main' into 31130-luster
badmintoncryer ae7f272
Merge branch 'main' into 31130-luster
badmintoncryer 3db6e3f
Merge branch 'main' into 31130-luster
badmintoncryer 5040122
Merge branch 'main' into 31130-luster
badmintoncryer 0345d15
Merge branch 'main' into 31130-luster
badmintoncryer 85de35c
update
badmintoncryer e6d16a3
Merge branch 'main' into 31130-luster
badmintoncryer 0cad430
Merge branch 'main' into 31130-luster
badmintoncryer b4f893e
Merge branch 'main' into 31130-luster
badmintoncryer eed44aa
Merge branch 'main' into 31130-luster
badmintoncryer 75dcaae
update jsdoc
badmintoncryer e040394
add comments
badmintoncryer 2f8987f
Merge remote-tracking branch 'origin/main' into 31130-luster
badmintoncryer afbc949
Merge branch 'main' into 31130-luster
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also validate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I described above,
LustreFileSystemProps
does not have metadata configuration prop and I think it is difficult to add validation for that.What do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I totally missed the note in the PR description. Since this prop doesn't exists yet, I think it's fine to skip this validation now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But can you add a TODO comment to indicate that we should add one once we support metadata config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added TODO comment. Could you please confirm?