chore(cloudfront): add validations on corsBehavior of ResponseHeadersPolicy #32206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
admired-contributor
Tietew
commented
Nov 20, 2024
| throw new Error('accessControlAllowHeaders needs to have at least one item'); | ||
| } else if (headers.some((header) => !Token.isUnresolved(header) && containsMultipleStars(header))) { | ||
| // Invalid request provided: AWS::CloudFront::ResponseHeadersPolicy | ||
| throw new Error("accessControlAllowHeaders contains multiple '*' chars; only 1 is allowed"); |
There was a problem hiding this comment.
Management Console shows error:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32206 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 105 105
Lines 7169 7169
Branches 1315 1315
=======================================
Hits 5533 5533
Misses 1455 1455
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
Currently, the values in
corsBehaviorofResponseHeadersPolicyhave no validations.This PR adds validations for user's convenience.
Description of changes
Added following validations for
corsBehavior:accessControlAllowHeaders: should be >= 1 items, should not contain multiple*chars, should not contain illegal charsaccessControlAllowMethods: should be['ALL']or set of allowed method namesaccessControlAllowOrigins: should be >= 1 itemsaccessControlExposeHeaders: should not contain illegal charsDescription of how you validated changes
Added unit tests on each edge case.
For details of the illegal characters above, see RFC 9110 section 5.6.2.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license