Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): add tls property to a ServiceConnectService #32605

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

ren-yamanashi
Copy link
Contributor

@ren-yamanashi ren-yamanashi commented Dec 20, 2024

Issue # (if applicable)

Closes #32583

Reason for this change

ServiceConnectService in ECS did not support the tls property.

Description of changes

  • Added tls property to ServiceConnectService(interface) in ECS(BaseService)
  • modified implementation to allow specifying ServiceConnectService tls in the enableServiceConnect method

Description of how you validated changes

Added unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 20, 2024 12:48
@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Dec 20, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@ren-yamanashi ren-yamanashi changed the title [WIP] feat: add tls property to a ServiceConnectService [WIP] feat(ecs): add tls property to a ServiceConnectService Dec 20, 2024
@ren-yamanashi ren-yamanashi changed the title [WIP] feat(ecs): add tls property to a ServiceConnectService feat(ecs): add tls property to a ServiceConnectService Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (3717f40) to head (881de2d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32605   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         222      222           
  Lines       13695    13695           
  Branches     2412     2412           
=======================================
  Hits        11145    11145           
  Misses       2271     2271           
  Partials      279      279           
Flag Coverage Δ
suite.unit 81.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.69% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 21, 2024 03:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@ren-yamanashi ren-yamanashi changed the title feat(ecs): add tls property to a ServiceConnectService feat(ecs): add tls property to a ServiceConnectService [WIP] Jan 12, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@ren-yamanashi
Copy link
Contributor Author

ren-yamanashi commented Jan 12, 2025

Exemption Request

This MR does not implement integration testing for the following reasons.

  1. AWS Private CA (PCA) is an expensive service and maintaining resources for testing is inefficient
  2. existing aws-acmpca module does not have integration test too
  3. test execution requires actual PCA, making it difficult to run in a CI environment

(This comment is based on a comment suggested at #32621)

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 12, 2025
@ren-yamanashi ren-yamanashi changed the title feat(ecs): add tls property to a ServiceConnectService [WIP] feat(ecs): add tls property to a ServiceConnectService Jan 12, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 881de2d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 12, 2025
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-ecs): Support TLS on ServiceConnect services
2 participants