-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(appsync): add placeholder Query type for improved schema compatibility #32633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Query
type for better GraphQL compatibility✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @azarboon
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32633 +/- ##
=======================================
Coverage 80.52% 80.52%
=======================================
Files 106 106
Lines 6948 6948
Branches 1287 1287
=======================================
Hits 5595 5595
Misses 1175 1175
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This pull request has been removed from the queue for the following reason: Pull request #32633 has been dequeued. The pull request has been synchronized by a user You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Pull request has been modified.
@Mergifyio requeue |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
@kaizencc Thanks for approving! I noticed the branch was out of sync, so I updated it. When the issue persisted, I synced my fork directly. It seems the issue is resolved now, but the PR still can't be merged. Since this is my first contribution to aws-cdk, I’d really appreciate your help in guiding me through the final steps. Thanks again! |
Closing this PR to start fresh with a clean branch. I’ll do my best to properly sync the new branch with the latest upstream changes and ensure it contains only the intended edits. A new PR will follow shortly. Thank you for your time and patience! |
Comments on closed issues and PRs are hard for our team to see. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #.
Reason for this change
While the current schema is technically valid with a single root
Mutation
type, most GraphQL clients and tools expect a defaultQuery
operation for introspection and standard queries. This PR introduces a minimal placeholderQuery
type to improve compatibility and align with common GraphQL conventions.Description of changes
Describe any new or updated permissions being added
<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license