Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(appsync): add placeholder Query type for improved schema compatibility #32633

Closed
wants to merge 5 commits into from

Conversation

azarboon
Copy link
Contributor

Issue # (if applicable)

Closes #.

Reason for this change

While the current schema is technically valid with a single root Mutation type, most GraphQL clients and tools expect a default Query operation for introspection and standard queries. This PR introduces a minimal placeholder Query type to improve compatibility and align with common GraphQL conventions.

Description of changes

Describe any new or updated permissions being added

<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Dec 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 22, 2024 07:53
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@azarboon azarboon changed the title Add placeholder Query type for better GraphQL compatibility fix(appsync): add placeholder Query type for GraphQL schema compliance Dec 22, 2024
@azarboon azarboon changed the title fix(appsync): add placeholder Query type for GraphQL schema compliance enhancement(appsync): add placeholder Query type for improved GraphQL schema compatibility Dec 22, 2024
@azarboon azarboon changed the title enhancement(appsync): add placeholder Query type for improved GraphQL schema compatibility feat(appsync): add placeholder Query type for improved schema compatibility Dec 22, 2024
@azarboon azarboon changed the title feat(appsync): add placeholder Query type for improved schema compatibility docs(appsync): add placeholder Query type for improved schema compatibility Dec 22, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 22, 2024 08:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 22, 2024
kaizencc
kaizencc previously approved these changes Dec 23, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @azarboon

Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.52%. Comparing base (0546ec2) to head (393ffec).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32633   +/-   ##
=======================================
  Coverage   80.52%   80.52%           
=======================================
  Files         106      106           
  Lines        6948     6948           
  Branches     1287     1287           
=======================================
  Hits         5595     5595           
  Misses       1175     1175           
  Partials      178      178           
Flag Coverage Δ
suite.unit 80.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.52% <ø> (ø)

Copy link
Contributor

mergify bot commented Dec 24, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32633 has been dequeued. The pull request has been synchronized by a user

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed kaizencc’s stale review December 24, 2024 00:19

Pull request has been modified.

@azarboon
Copy link
Contributor Author

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Dec 24, 2024

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@azarboon
Copy link
Contributor Author

@kaizencc Thanks for approving! I noticed the branch was out of sync, so I updated it. When the issue persisted, I synced my fork directly. It seems the issue is resolved now, but the PR still can't be merged. Since this is my first contribution to aws-cdk, I’d really appreciate your help in guiding me through the final steps. Thanks again!

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 24, 2024
@azarboon
Copy link
Contributor Author

Closing this PR to start fresh with a clean branch. I’ll do my best to properly sync the new branch with the latest upstream changes and ensure it contains only the intended edits. A new PR will follow shortly. Thank you for your time and patience!

@azarboon azarboon closed this Dec 24, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5c4bec4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants