fix(aspects): "localAspects is not iterable" error

packages/aws-cdk-lib/core/lib/private/synthesis.ts

@@ -8,7 +8,7 @@ import { CloudAssembly } from '../../../cx-api';
 import * as cxapi from '../../../cx-api';
 import { Annotations } from '../annotations';
 import { App } from '../app';
-import { AspectApplication, Aspects } from '../aspect';
+import { AspectApplication, AspectPriority, Aspects } from '../aspect';
 import { FileSystem } from '../fs';
 import { Stack } from '../stack';
 import { ISynthesisSession } from '../stack-synthesizers/types';
@@ -228,7 +228,7 @@ function invokeAspects(root: IConstruct) {
     const node = construct.node;
     const aspects = Aspects.of(construct);
 
-    let localAspects = aspects.applied;
+    let localAspects = getAspectApplications(construct);
     const allAspectsHere = sortAspectsByPriority(inheritedAspects, localAspects);
 
     const nodeAspectsCount = aspects.all.length;
@@ -290,11 +290,10 @@ function invokeAspectsV2(root: IConstruct) {
 
   function recurse(construct: IConstruct, inheritedAspects: AspectApplication[]): boolean {
     const node = construct.node;
-    const aspects = Aspects.of(construct);
 
     let didSomething = false;
 
-    let localAspects = aspects.applied;
+    let localAspects = getAspectApplications(construct);
     const allAspectsHere = sortAspectsByPriority(inheritedAspects, localAspects);
 
     for (const aspectApplication of allAspectsHere) {
@@ -354,6 +353,21 @@ function sortAspectsByPriority(inheritedAspects: AspectApplication[], localAspec
   return allAspects;
 }
 
+/**
+ * Helper function to get aspect applications.
+ * If `Aspects.applied` is available, it is used; otherwise, create AspectApplications from `Aspects.all`.
+ */
+function getAspectApplications(node: IConstruct): AspectApplication[] {
+  const aspects = Aspects.of(node);
+  if (aspects.applied !== undefined) {
+    return aspects.applied;
+  }
+
+  // Fallback: Create AspectApplications from `aspects.all`
+  const typedAspects = aspects as Aspects;
+  return typedAspects.all.map(aspect => new AspectApplication(node, aspect, AspectPriority.DEFAULT));
+}
+
 /**
  * Find all stacks and add Metadata Resources to all of them
  *

packages/aws-cdk-lib/core/test/aspect.test.ts

@@ -309,4 +309,24 @@ describe('aspect', () => {
       }
     }
   }
+
+  test.each([
+    { stabilization: true },
+    { stabilization: false },
+  ])('Error is not thrown if Aspects.applied does not exist (stabilization: $stabilization)', ({ stabilization }) => {
+    const app = new App({ context: { '@aws-cdk/core:aspectStabilization': stabilization } });
+    const root = new Stack(app, 'My-Stack');
+
+    Aspects.of(root).add(new Tag('AspectA', 'Visited'));
+
+    // "Monkey patching" - Override `applied` to simulate its absence
+    Object.defineProperty(Aspects.prototype, 'applied', {
+      value: undefined,
+      configurable: true,
+    });
+
+    expect(() => {
+      app.synth();
+    }).not.toThrow();
+  });
 });

tools/@aws-cdk/yargs-gen/lib/index.d.ts

@@ -0,0 +1,2 @@
+export * from './yargs-gen';
+export * from './yargs-types';

tools/@aws-cdk/yargs-gen/lib/yargs-gen.d.ts

@@ -0,0 +1,9 @@
+import { Expression, ExternalModule } from '@cdklabs/typewriter';
+import { CliConfig } from './yargs-types';
+export declare class CliHelpers extends ExternalModule {
+    readonly browserForPlatform: import("@cdklabs/typewriter").ExpressionProxy<Expression>;
+    readonly cliVersion: import("@cdklabs/typewriter").ExpressionProxy<Expression>;
+    readonly isCI: import("@cdklabs/typewriter").ExpressionProxy<Expression>;
+    readonly yargsNegativeAlias: import("@cdklabs/typewriter").ExpressionProxy<Expression>;
+}
+export declare function renderYargs(config: CliConfig, helpers: CliHelpers): Promise<string>;

tools/@aws-cdk/yargs-gen/lib/yargs-types.d.ts

@@ -0,0 +1,56 @@
+interface YargsCommand {
+    description: string;
+    options?: {
+        [optionName: string]: YargsOption;
+    };
+    aliases?: string[];
+    arg?: YargsArg;
+}
+interface CliAction extends YargsCommand {
+    options?: {
+        [optionName: string]: CliOption;
+    };
+}
+interface YargsArg {
+    name: string;
+    variadic: boolean;
+}
+export interface YargsOption {
+    type: 'string' | 'array' | 'number' | 'boolean' | 'count';
+    desc?: string;
+    default?: any;
+    deprecated?: boolean | string;
+    choices?: ReadonlyArray<string | number | true | undefined>;
+    alias?: string | string[];
+    conflicts?: string | readonly string[] | {
+        [key: string]: string | readonly string[];
+    };
+    nargs?: number;
+    requiresArg?: boolean;
+    hidden?: boolean;
+    count?: boolean;
+}
+export interface CliOption extends Omit<YargsOption, 'nargs' | 'hidden'> {
+    negativeAlias?: string;
+}
+export interface Middleware {
+    callback: string;
+    args: string[];
+    applyBeforeValidation?: boolean;
+}
+export interface CliConfig {
+    globalOptions: {
+        [optionName: string]: CliOption;
+    };
+    commands: {
+        [commandName: string]: CliAction;
+    };
+}
+/**
+ * The result of a DynamicValue call
+ */
+export interface DynamicResult {
+    dynamicType: 'parameter' | 'function';
+    dynamicValue: string;
+}
+export {};

tools/@aws-cdk/yargs-gen/test/cli.test.d.ts

@@ -0,0 +1 @@
+export {};