-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): use correct formatting for aggregate errors in aws-cdk
#32817
Conversation
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Signed-off-by: Sumu <sumughan@amazon.com>
aws-cdk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32817 +/- ##
==========================================
+ Coverage 81.38% 81.41% +0.03%
==========================================
Files 222 223 +1
Lines 13698 13721 +23
Branches 2413 2416 +3
==========================================
+ Hits 11148 11171 +23
Misses 2271 2271
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Sumu <sumughan@amazon.com>
@@ -0,0 +1,11 @@ | |||
export function formatErrorMessage(error: any): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose do add a test for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did see packages/aws-cdk/test/api/util/error.test.ts
Signed-off-by: Sumu <sumughan@amazon.com>
…m/aws/aws-cdk into sumughan/aggregate-error-handling
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Comments on closed issues and PRs are hard for our team to see. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Closes #32237
Reason for this change
Sometimes when we print
e.message
,e
is anAggegateError
- so the message text is incomplete/not formatted correctly. This PR adds a new util function,formatErrorMessage
which returnse.message
if it exists, or a correctly formatted string of errors ife
is anAggregateError
.Description of changes
See
formatErrorMessage
function in the newly created file,packages/aws-cdk/lib/util/error.ts
. All other changes are grunt work replacinge.message
withformateErrorMessage(e)
. This PR only does the finding and replacing in theaws-cdk
package, TBD whether we need to do the same for the rest of the repo.Describe any new or updated permissions being added
None
Description of how you validated changes
See unit tests in
packages/aws-cdk/test/api/util/error.test.ts
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license