-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add metadata import and statement updater #32896
Open
GavinZZ
wants to merge
1
commit into
yuanhaoz/feat/metadata-collection
Choose a base branch
from
yuanhaoz/feat/metadata-collection-importer
base: yuanhaoz/feat/metadata-collection
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: add metadata import and statement updater #32896
GavinZZ
wants to merge
1
commit into
yuanhaoz/feat/metadata-collection
from
yuanhaoz/feat/metadata-collection-importer
+4,393
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinZZ
force-pushed
the
yuanhaoz/feat/metadata-collection-importer
branch
from
January 13, 2025 20:05
06edbd2
to
53577de
Compare
GavinZZ
changed the title
chore(aws-cdk-lib): add metadata import and statement updater
chore: add metadata import and statement updater
Jan 13, 2025
GavinZZ
force-pushed
the
yuanhaoz/feat/metadata-collection-importer
branch
from
January 14, 2025 03:37
53577de
to
4cf55d3
Compare
GavinZZ
force-pushed
the
yuanhaoz/feat/metadata-collection-importer
branch
2 times, most recently
from
January 16, 2025 01:23
7f7d372
to
b41b6e5
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
label
Jan 16, 2025
GavinZZ
changed the base branch from
main
to
yuanhaoz/feat/metadata-collection
January 16, 2025 23:20
GavinZZ
force-pushed
the
yuanhaoz/feat/metadata-collection-importer
branch
from
January 18, 2025 01:02
b41b6e5
to
dd89c4f
Compare
GavinZZ
changed the base branch from
yuanhaoz/feat/metadata-collection
to
main
January 18, 2025 01:02
Changing the target branch to |
GavinZZ
changed the base branch from
main
to
yuanhaoz/feat/metadata-collection
January 20, 2025 18:54
samson-keung
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution/core
This is a PR that came from AWS.
p2
pr/do-not-merge
This PR should not be merged at this time.
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Reason for this change
As a follow up to #32827. We need to add metadata statement to the constructor to every L2 constructs that inherits
Resource
class. We usedts-morph
as the typescript parser to parse all CDK files and find the constructs that match the requirements.Add import statement and
this.node.addMetadata(
statement to the file.Description of changes
Main change is a one-time tool
metadata-updater
to automatically find the right classes and add import statements and add metadata statements. The tool can be run multiple times and should not add additional import or add metadata statements to files that already been added.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license