-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): watch is fully configurable from CLI #32903
base: conroy/refact
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
* | ||
* @default 'cdk.out' | ||
*/ | ||
readonly output?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure we can just get that from the assembly itself.
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
1 similar comment
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Related to #32473. This PR fixes it, but is not targeting
main
.This PR is meant to pull out a specific feature that still depends on #32760. We are adding
include
andexclude
options todeploy
andwatch
.watch.include/exclude
matches 1-1 with what is expected out ofcdk.json
today, so those properties end up merged together in the sameSettings
object. There are some legacy considerations, likecdk.json
allows a single string instead of a string array, but that does not make sense for the CLI as those are automatically converted to arrays.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license