Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(README): remove Mergify badge #32963

Merged
merged 2 commits into from
Jan 18, 2025
Merged

chore(README): remove Mergify badge #32963

merged 2 commits into from
Jan 18, 2025

Conversation

ScottBrenner
Copy link
Contributor

@ScottBrenner ScottBrenner commented Jan 16, 2025

Reason for this change

Badge does not render properly

Description of changes

Removing this badge that does not render properly, or alternatively follow https://docs.mergify.com/badge/#finding-the-badge-url to restore if still applicable

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 16, 2025 04:10
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 16, 2025
@ScottBrenner ScottBrenner changed the title Remove Mergify badge from README.md docs(README): Remove Mergify badge Jan 16, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@ScottBrenner ScottBrenner changed the title docs(README): Remove Mergify badge docs(README): remove Mergify badge Jan 16, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 16, 2025 04:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 16, 2025
mrgrain
mrgrain previously approved these changes Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 16, 2025
@mrgrain mrgrain changed the title docs(README): remove Mergify badge chore(README): remove Mergify badge Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review January 18, 2025 02:47

Pull request has been modified.

@ScottBrenner ScottBrenner requested a review from mrgrain January 18, 2025 02:54
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4b3e5c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 18, 2025
Copy link
Contributor

mergify bot commented Jan 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 18, 2025
@mrgrain
Copy link
Contributor

mrgrain commented Jan 18, 2025

@ScottBrenner thanks for the ping again! I'll try to watch it a bit more closely this time. This PR is particularly tricky because it's your first one here and I have to manually approve the builds 😅

For the future, you don't need to update changes from main, after you have gotten an approval. Automation should take care of everything! Unless there's a conflict of course. In fact updating using the UI button makes it even more complicated, cause the PR needs to be re-reviewed then. 🙈

Copy link
Contributor

mergify bot commented Jan 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (1889527) to head (4b3e5c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32963   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files         225      225           
  Lines       13714    13714           
  Branches     2411     2411           
=======================================
  Hits        11162    11162           
  Misses       2277     2277           
  Partials      275      275           
Flag Coverage Δ
suite.unit 81.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.70% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@mergify mergify bot merged commit 53dc0d8 into aws:main Jan 18, 2025
28 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants