Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(toolkit): destroy tests #33002

Merged
merged 21 commits into from
Jan 18, 2025
Merged

test(toolkit): destroy tests #33002

merged 21 commits into from
Jan 18, 2025

Conversation

kaizencc
Copy link
Contributor

Add tests for the destroy action


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 17, 2025 23:12
@github-actions github-actions bot added the p2 label Jan 17, 2025
@kaizencc kaizencc changed the base branch from main to conroy/deploy-more-tests January 17, 2025 23:12
@kaizencc kaizencc requested a review from a team as a code owner January 17, 2025 23:12
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 17, 2025
Base automatically changed from conroy/deploy-more-tests to main January 17, 2025 23:26
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (28067b0) to head (3241cd2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33002   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files         225      225           
  Lines       13714    13714           
  Branches     2411     2411           
=======================================
  Hits        11162    11162           
  Misses       2277     2277           
  Partials      275      275           
Flag Coverage Δ
suite.unit 81.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.70% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

Copy link
Contributor

mergify bot commented Jan 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3241cd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1889527 into main Jan 18, 2025
19 checks passed
Copy link
Contributor

mergify bot commented Jan 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the conroy/destroy-some-tests branch January 18, 2025 01:35
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants