Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): mpl head step for rust #1583

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

josecorella
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@josecorella josecorella requested a review from a team as a code owner January 21, 2025 18:50
git checkout main
git pull
git submodule update --init --recursive
git rev-parse HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why do we need this? Is this to log current commit hash in CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you do the normal submodule checkout in the set up above that only checks out the commit that is being tracked by the repo.
by going into the submodule and checking out the latest explicitly we make sure we pull all the latest changes including submodule changes within the mpl.
the git rev-parse HEAD is a stdout message for us to visually check it is the latest.

Copy link
Member

@rishav-karanjit rishav-karanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise looks good to me

Copy link
Member

@rishav-karanjit rishav-karanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josecorella josecorella merged commit 98724d3 into main Jan 21, 2025
43 checks passed
@josecorella josecorella deleted the jocorell/fix-mpl-daily-ci branch January 21, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants