Users don't need to hold the payload until publish complete (#252)

- underlying lib updated to keep deep copy of the publish payload, thus we don't need to keep the payload alive until publish complete
aws · Apr 7, 2021 · 4a7bc29 · 4a7bc29
1 parent 6abdaa0
commit 4a7bc29
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/crt/aws-crt-cpp b/crt/aws-crt-cpp
diff --git a/samples/mqtt/basic_pub_sub/main.cpp b/samples/mqtt/basic_pub_sub/main.cpp
@@ -540,12 +540,9 @@ int main(int argc, char *argv[])
                 break;
             }
 
-            ByteBuf payload = ByteBufNewCopy(DefaultAllocator(), (const uint8_t *)input.data(), input.length());
-            ByteBuf *payloadPtr = &payload;
-
-            auto onPublishComplete = [payloadPtr](Mqtt::MqttConnection &, uint16_t packetId, int errorCode) {
-                aws_byte_buf_clean_up(payloadPtr);
+            ByteBuf payload = ByteBufFromArray((const uint8_t *)input.data(), input.length());
 
+            auto onPublishComplete = [](Mqtt::MqttConnection &, uint16_t packetId, int errorCode) {
                 if (packetId)
                 {
                     fprintf(stdout, "Operation on packetId %d Succeeded\n", packetId);

diff --git a/samples/mqtt/raw_pub_sub/main.cpp b/samples/mqtt/raw_pub_sub/main.cpp
@@ -413,12 +413,9 @@ int main(int argc, char *argv[])
                 break;
             }
 
-            ByteBuf payload = ByteBufNewCopy(DefaultAllocator(), (const uint8_t *)input.data(), input.length());
-            ByteBuf *payloadPtr = &payload;
-
-            auto onPublishComplete = [payloadPtr](Mqtt::MqttConnection &, uint16_t packetId, int errorCode) {
-                aws_byte_buf_clean_up(payloadPtr);
+            ByteBuf payload = ByteBufFromArray((const uint8_t *)input.data(), input.length());
 
+            auto onPublishComplete = [](Mqtt::MqttConnection &, uint16_t packetId, int errorCode) {
                 if (packetId)
                 {
                     fprintf(stdout, "Operation on packetId %d Succeeded\n", packetId);
+2 −2		.github/workflows/ci.yml
+2 −2		CMakeLists.txt
+5 −5		README.md
+0 −1		builder.json
+1 −1		codebuild/common-posix.sh
+1 −1		codebuild/common-windows.bat
+1 −1		crt/aws-c-mqtt
+2 −1		include/aws/crt/StlAllocator.h