Mqtt5 Device Defender Support #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfod
approved these changes
Oct 25, 2023
| const Crt::String &thingName) | ||
| : ReportTaskBuilder( | ||
| allocator, | ||
| Crt::Mqtt::MqttConnection::NewConnectionFromMqtt5Client(mqtt5Client), |
There was a problem hiding this comment.
nit: mqtt5Client can be moved here:
Suggested change
| Crt::Mqtt::MqttConnection::NewConnectionFromMqtt5Client(mqtt5Client), | |
| Crt::Mqtt::MqttConnection::NewConnectionFromMqtt5Client(std::move(mqtt5Client)), |
| static int s_TestMqtt5DeviceDefenderResourceSafety(Aws::Crt::Allocator *allocator, void *ctx) | ||
| { | ||
| (void)ctx; | ||
| { |
There was a problem hiding this comment.
nit: This new scope contains the whole function body. Is it really required here?
| static int s_TestMqtt5DeviceDefenderFailedTest(Aws::Crt::Allocator *allocator, void *ctx) | ||
| { | ||
| (void)ctx; | ||
| { |
There was a problem hiding this comment.
nit: Another new scope containing the whole body
| To run the Device Defender sample, use the following command: | ||
|
|
||
| ``` sh | ||
| ./basic-report --endpoint <endpoint> --cert <path to the certificate> --key <path to the private key> --thing_name <thing name> --ca_file <path to root CA> |
There was a problem hiding this comment.
The binary should be mqtt5-basic-report
| You can also pass a Certificate Authority file (CA) if your certificate and key combination requires it: | ||
|
|
||
| ``` sh | ||
| ./basic-report --endpoint <endpoint> --cert <path to the certificate> --key <path to the private key> --thing_name <thing name> --ca_file <path to root CA> |
There was a problem hiding this comment.
The binary should be mqtt5-basic-report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.