Add support for building with MinGW #1333
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds support for building aws-sdk-cpp with the MinGW toolchain on Windows.
Needs awslabs/aws-c-common#604 in order to work.
The main changes are adding checks for the MINGW32 define which is preset on both 32 and 64 bit MinGW installations, silencing some bogus warnings and addressing some
0
vsNULL
cases which gcc complains about.I don't this this needs explicit tests but might need additional CI work to ensure MinGW continues to work in the future.
Regarding ReadMe/Wiki: It might need mentioning that building with MinGW is supported.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.