Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smithy refactor Json protocol with Single direction EventStreaming (v4/v4a/bearer) #3212

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3973d48
version 0: refactor with smithy client for json protocol non customized
sbera87 Nov 27, 2024
8867b8b
cleanup
sbera87 Dec 12, 2024
f333753
refactor for smithy/legacy json clients
sbera87 Dec 13, 2024
cbc6b8f
tweak
sbera87 Dec 13, 2024
a99e702
al2 compilaiton fix, pr comment address
sbera87 Dec 15, 2024
7e17cbe
fix for category of services with stream members with examples
sbera87 Dec 17, 2024
7b08305
add support for path segment of different types
sbera87 Dec 17, 2024
aeb4287
dry run fix for path segments greater than one case
sbera87 Dec 18, 2024
a9768c8
exclude customization services and rename method to avoid shadowing c…
sbera87 Dec 18, 2024
13393cb
removing streaming
sbera87 Dec 19, 2024
790a441
remove event streaming
sbera87 Dec 19, 2024
1d7c618
remove bidirectional event streaming changes
sbera87 Dec 20, 2024
dec045a
fix to accomodate more clients
sbera87 Dec 20, 2024
453f112
fix in codegen for loop variable
sbera87 Dec 22, 2024
004145e
change tests for smithy client not copyable
sbera87 Jan 2, 2025
b796422
namespace resolution of AWS Error
sbera87 Jan 2, 2025
802556a
efs client changes
sbera87 Jan 6, 2025
22c5b10
merge changes
sbera87 Jan 7, 2025
9c042fa
fix rfc paths for smithy clients
sbera87 Jan 8, 2025
601d6e3
fix query string
sbera87 Jan 10, 2025
24104d4
changes for presigner
sbera87 Jan 10, 2025
19b7945
presigner support
sbera87 Jan 12, 2025
65e9c06
merge changes from mainline
sbera87 Jan 12, 2025
95b2966
merge useragent changes
sbera87 Jan 14, 2025
8e9e896
merges from main
sbera87 Jan 14, 2025
a84fdba
fix merge conflict
sbera87 Jan 14, 2025
3e3f242
exclude bidirectional streaming client
sbera87 Jan 14, 2025
6c73fee
address pr comments + cleanup
sbera87 Jan 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,19 @@
#pragma once
#include <aws/appconfig/AppConfig_EXPORTS.h>
#include <aws/core/client/ClientConfiguration.h>
#include <aws/core/client/AWSClient.h>
#include <aws/core/client/AWSClientAsyncCRTP.h>
#include <aws/core/utils/json/JsonSerializer.h>
#include <aws/appconfig/AppConfigServiceClientModel.h>
#include <smithy/client/AwsSmithyClient.h>
#include <smithy/identity/auth/built-in/SigV4AuthSchemeResolver.h>
#include <smithy/identity/auth/built-in/SigV4AuthScheme.h>
#include <smithy/client/serializer/JsonOutcomeSerializer.h>
#include <aws/appconfig/AppConfigErrorMarshaller.h>

namespace Aws
{
namespace AppConfig
{
AWS_APPCONFIG_API extern const char SERVICE_NAME[];
/**
* <p>AppConfig feature flags and dynamic configurations help software builders
* quickly and securely adjust application behavior in production environments
Expand Down Expand Up @@ -111,12 +115,20 @@ namespace AppConfig
* href="http://docs.aws.amazon.com/appconfig/latest/userguide/what-is-appconfig.html">AppConfig
* User Guide</a>.</p>
*/
class AWS_APPCONFIG_API AppConfigClient : public Aws::Client::AWSJsonClient, public Aws::Client::ClientWithAsyncTemplateMethods<AppConfigClient>
class AWS_APPCONFIG_API AppConfigClient : smithy::client::AwsSmithyClientT<Aws::AppConfig::SERVICE_NAME,
Aws::AppConfig::AppConfigClientConfiguration,
smithy::SigV4AuthSchemeResolver<>,
Aws::Crt::Variant<smithy::SigV4AuthScheme>,
AppConfigEndpointProviderBase,
smithy::client::JsonOutcomeSerializer,
smithy::client::JsonOutcome,
Aws::Client::AppConfigErrorMarshaller>,
Aws::Client::ClientWithAsyncTemplateMethods<AppConfigClient>
{
public:
typedef Aws::Client::AWSJsonClient BASECLASS;
static const char* GetServiceName();
static const char* GetAllocationTag();
inline const char* GetServiceClientName() const override { return "AppConfig"; }

typedef AppConfigClientConfiguration ClientConfigurationType;
typedef AppConfigEndpointProvider EndpointProviderType;
Expand Down Expand Up @@ -1395,10 +1407,7 @@ namespace AppConfig
std::shared_ptr<AppConfigEndpointProviderBase>& accessEndpointProvider();
private:
friend class Aws::Client::ClientWithAsyncTemplateMethods<AppConfigClient>;
void init(const AppConfigClientConfiguration& clientConfiguration);

AppConfigClientConfiguration m_clientConfiguration;
std::shared_ptr<AppConfigEndpointProviderBase> m_endpointProvider;
};

} // namespace AppConfig
Expand Down
1,092 changes: 429 additions & 663 deletions generated/src/aws-cpp-sdk-appconfig/source/AppConfigClient.cpp

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,19 @@
#pragma once
#include <aws/appconfigdata/AppConfigData_EXPORTS.h>
#include <aws/core/client/ClientConfiguration.h>
#include <aws/core/client/AWSClient.h>
#include <aws/core/client/AWSClientAsyncCRTP.h>
#include <aws/core/utils/json/JsonSerializer.h>
#include <aws/appconfigdata/AppConfigDataServiceClientModel.h>
#include <smithy/client/AwsSmithyClient.h>
#include <smithy/identity/auth/built-in/SigV4AuthSchemeResolver.h>
#include <smithy/identity/auth/built-in/SigV4AuthScheme.h>
#include <smithy/client/serializer/JsonOutcomeSerializer.h>
#include <aws/appconfigdata/AppConfigDataErrorMarshaller.h>

namespace Aws
{
namespace AppConfigData
{
AWS_APPCONFIGDATA_API extern const char SERVICE_NAME[];
/**
* <p>AppConfig Data provides the data plane APIs your application uses to retrieve
* configuration data. Here's how it works:</p> <p>Your application retrieves
Expand Down Expand Up @@ -57,12 +61,20 @@ namespace AppConfigData
* href="http://docs.aws.amazon.com/appconfig/latest/userguide/appconfig-retrieving-the-configuration">Retrieving
* the configuration</a> in the <i>AppConfig User Guide</i>.</p>
*/
class AWS_APPCONFIGDATA_API AppConfigDataClient : public Aws::Client::AWSJsonClient, public Aws::Client::ClientWithAsyncTemplateMethods<AppConfigDataClient>
class AWS_APPCONFIGDATA_API AppConfigDataClient : smithy::client::AwsSmithyClientT<Aws::AppConfigData::SERVICE_NAME,
Aws::AppConfigData::AppConfigDataClientConfiguration,
smithy::SigV4AuthSchemeResolver<>,
Aws::Crt::Variant<smithy::SigV4AuthScheme>,
AppConfigDataEndpointProviderBase,
smithy::client::JsonOutcomeSerializer,
smithy::client::JsonOutcome,
Aws::Client::AppConfigDataErrorMarshaller>,
Aws::Client::ClientWithAsyncTemplateMethods<AppConfigDataClient>
{
public:
typedef Aws::Client::AWSJsonClient BASECLASS;
static const char* GetServiceName();
static const char* GetAllocationTag();
inline const char* GetServiceClientName() const override { return "AppConfigData"; }

typedef AppConfigDataClientConfiguration ClientConfigurationType;
typedef AppConfigDataEndpointProvider EndpointProviderType;
Expand Down Expand Up @@ -189,10 +201,7 @@ namespace AppConfigData
std::shared_ptr<AppConfigDataEndpointProviderBase>& accessEndpointProvider();
private:
friend class Aws::Client::ClientWithAsyncTemplateMethods<AppConfigDataClient>;
void init(const AppConfigDataClientConfiguration& clientConfiguration);

AppConfigDataClientConfiguration m_clientConfiguration;
std::shared_ptr<AppConfigDataEndpointProviderBase> m_endpointProvider;
};

} // namespace AppConfigData
Expand Down
Loading
Loading