Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer.json #3243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create devcontainer.json #3243

wants to merge 1 commit into from

Conversation

hmd123pm
Copy link

@hmd123pm hmd123pm commented Jan 12, 2025

Issue #, if available:

Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl
Copy link
Contributor

not 100 percent sure whats going on here, if you are indeed trying to make a PR to aws repo, please fill out a description so we know what the contents of the PR are and what you are trying to accomplish with it.

all of that said looks like you're trying to commit a dev containers file for use in vscode. I'm not opposed to having a dev container file, but likely would not want it to be a microsoft base and be a base AL2 or AL2023 from amazon linux's public ecr.

If you want us to create a AL2023 base dev container file, feel free to open a issue/feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants