Fix: mutex deadlock (#393)

Co-authored-by: Prashant Srivastava <50466688+srprash@users.noreply.github.com>
aws · Jan 31, 2023 · 7df7dc4 · 7df7dc4
1 parent bd15b17
commit 7df7dc4
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/xray/segment.go b/xray/segment.go
@@ -405,19 +405,21 @@ func (seg *Segment) CloseAndStream(err error) {
 	if SdkDisabled() {
 		return
 	}
-
-	seg.Lock()
-	defer seg.Unlock()
-
+
 	if seg.parent != nil {
 		logger.Debugf("Ending subsegment named: %s", seg.Name)
+		seg.Lock()
 		seg.EndTime = float64(time.Now().UnixNano()) / float64(time.Second)
 		seg.InProgress = false
 		seg.Emitted = true
+		seg.Unlock()
 		if seg.parent.RemoveSubsegment(seg) {
 			logger.Debugf("Removing subsegment named: %s", seg.Name)
 		}
 	}
+
+	seg.Lock()
+	defer seg.Unlock()
 
 	if err != nil {
 		seg.addError(err)