-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fasthttp dependency from v1.50.0 to v1.52.0 #477
update fasthttp dependency from v1.50.0 to v1.52.0 #477
Conversation
…y vulnerability in v1.50.0 swcap[#time 3m0s #project 0 #wt 9]
Thanks for contributing PR to fix the security issue. The PR checks get some failures and it blocks the PR merge. Would you please help update the PR to fix the failures? |
swcap[#time 1m0s #project 0 #wt 9]
swcap[#time 5m0s #project 0 #wt 9]
@vastin Can you approve the new runs? I was able to test this locally and they are passing
|
swcap[#time 5m0s #project 0 #wt 9]
Apologies @vastin, I still used go1.23 locally. I installed 1.20 locally and ensured the go.mod file is valid for that version of go. |
Hi ddouglas, thank you for the effort. Please run test with go 1.19 and go 1.20 which are required in PR checks. |
swcap[#time 1m0s #project 0 #wt 9]
I reran the tests locally in docker. I had to make some changes to the go.mod file, but this should be correct now. |
For tracking purpose, the PR is closed in favor of #478 |
PR to address a security issue in v1.50.0 of fasthttp where a private key was included in the version
Issue #, if available:
Description of changes:
Bump version of fasthttp from v1.50.0 => v1.57.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.