Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft | Checksum issue #388

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/s3_data_plane_tests.c
Original file line number Diff line number Diff line change
Expand Up @@ -3477,7 +3477,7 @@ static int s_test_s3_round_trip_multipart_get_fc(struct aws_allocator *allocator
struct aws_s3_tester tester;
ASSERT_SUCCESS(aws_s3_tester_init(allocator, &tester));
struct aws_s3_tester_client_options client_options = {
.part_size = 16 * 1024,
.part_size = MB_TO_BYTES(5),
};

struct aws_s3_client *client = NULL;
Expand All @@ -3499,14 +3499,18 @@ static int s_test_s3_round_trip_multipart_get_fc(struct aws_allocator *allocator
.validate_get_response_checksum = false,
.put_options =
{
.object_size_mb = 1,
.object_size_mb = 10,
.object_path_override = object_path,
},
};

ASSERT_SUCCESS(aws_s3_tester_send_meta_request_with_options(&tester, &put_options, NULL));

client = aws_s3_client_release(client);
tester.bound_to_client = false;
/*** GET FILE ***/
client_options.part_size = MB_TO_BYTES(20);
ASSERT_SUCCESS(aws_s3_tester_client_new(&tester, &client_options, &client));

struct aws_s3_tester_meta_request_options get_options = {
.allocator = allocator,
Expand Down Expand Up @@ -3569,8 +3573,12 @@ static int s_test_s3_round_trip_mpu_multipart_get_fc(struct aws_allocator *alloc
};

ASSERT_SUCCESS(aws_s3_tester_send_meta_request_with_options(&tester, &put_options, NULL));
client = aws_s3_client_release(client);
tester.bound_to_client = false;

/*** GET FILE ***/
client_options.part_size = MB_TO_BYTES(20);
ASSERT_SUCCESS(aws_s3_tester_client_new(&tester, &client_options, &client));

struct aws_s3_tester_meta_request_options get_options = {
.allocator = allocator,
Expand Down
Loading