msvc fix, more formatting, append compiler flag rather than resetting…

… it.
awslabs · Jan 18, 2024 · 53fb00f · 53fb00f
1 parent 145267d
commit 53fb00f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -163,7 +163,7 @@ if (USE_CPU_EXTENSIONS AND AWS_ARCH_INTEL)
    simd_add_source_avx(${PROJECT_NAME} ${AWS_ARCH_SRC})
 
     if (NOT MSVC AND AWS_HAVE_AVX512_INTRINSICS)
-        SET_SOURCE_FILES_PROPERTIES(${AWS_ARCH_SRC} PROPERTIES COMPILE_FLAGS "-mavx512vl")
+        set_property(SOURCE ${AWS_ARCH_SRC} APPEND PROPERTY COMPILE_OPTIONS -mavx512vl)
     endif()
 endif()
 

diff --git a/source/crc64.c b/source/crc64.c
@@ -57,7 +57,7 @@ cheksums_constants aws_checksums_crc64xz_constants = {
              0x6ae3efbb9dd441f3,
              0x081f6054a7842df4, //
              0x6ae3efbb9dd441f3,
-             0x081f6054a7842df4},                            //
+             0x081f6054a7842df4},                        //
     .x384 = {0xb5ea1af9c013aca4, 0x69a35d91c3730254},    //  x^448 mod P(x) / x^384 mod P(x)
     .x256 = {0x60095b008a9efa44, 0x3be653a30fe1af51},    //  x^320 mod P(x) / x^256 mod P(x)
     .x128 = {0xe05dd497ca393ae4, 0xdabe95afc7875f40},    //  x^192 mod P(x) / x^128 mod P(x)

diff --git a/tests/crc64_test.c b/tests/crc64_test.c
@@ -11,7 +11,7 @@
 static const uint64_t POLY_CRC64XZ = 0xc96c5795d7870f42;
 
 // Any input with the CRC of that input appended should produce this CRC value. (Note: inverting the bits)
-static const uint64_t RESIDUE_CRC64XZ = ~0x49958c9abd7d353f;
+static const uint64_t RESIDUE_CRC64XZ = (uint64_t)~0x49958c9abd7d353f;
 
 static const uint8_t DATA_32_ZEROS[32] = {0};
 static const uint64_t KNOWN_CRC64XZ_32_ZEROES = 0xC95AF8617CD5330C;