Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use edgy.nvim to define window layout. #1393

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Jan 9, 2025

This patch add edgy.nvim to define window layout for better workflow. WIP and need more voice @greggh @CharlesChiuGit

@ayamir

This comment was marked as outdated.

@greggh
Copy link

greggh commented Jan 9, 2025

That is exactly what I was hoping for. This is amazing.

Do the other Trouble windows like definitions and so on, all open on the right as well, under the Symbols?

@ayamir

This comment was marked as outdated.

@ayamir
Copy link
Owner Author

ayamir commented Jan 10, 2025

Do the other Trouble windows like definitions and so on, all open on the right as well, under the Symbols?

Just found out that trouble already supports the display of lsp functionalities, I will try to arrange them as reasonably as possible.

@ayamir

This comment was marked as outdated.

@greggh
Copy link

greggh commented Jan 10, 2025

That is awesome.

@ayamir
Copy link
Owner Author

ayamir commented Jan 10, 2025

It looks like this now (with nvim-tree):

image

@ayamir ayamir requested a review from Jint-lzxy January 10, 2025 13:49
@ayamir ayamir marked this pull request as ready for review January 10, 2025 13:49
@ayamir ayamir requested a review from CharlesChiuGit January 10, 2025 13:49
@ayamir
Copy link
Owner Author

ayamir commented Jan 13, 2025

@greggh Have you tried this?

@greggh
Copy link

greggh commented Jan 13, 2025

@greggh Have you tried this?

Not yet, ill have time to try it later today. Was a super busy weekend. Thanks for all the effort here, it looks great. I'll respond later after I get a chance to play with it.

@greggh
Copy link

greggh commented Jan 13, 2025

This is great. It is doing exactly what I hoped it would. I would love it if the quickfix list went down to the bottom just like the toggleterm and help properly.

The "go" key bind does what I wanted and works great with the LSPs I am working with.

Edit:
It would also be great to have one key bind that is sort of the focus / full-ide key bind. So when I press those keys it does exactly what control-n, gt, and go all do at once. It would take me from an open buffer that is my full screen to my "full ide" in one key bind.

@ayamir
Copy link
Owner Author

ayamir commented Jan 14, 2025

I would love it if the quickfix list went down to the bottom just like the toggleterm and help properly.

It has already configured. Do you mean Trouble project_diagnostics window?

@ayamir
Copy link
Owner Author

ayamir commented Jan 14, 2025

It would also be great to have one key bind that is sort of the focus / full-ide key bind. So when I press those keys it does exactly what control-n, gt, and go all do at once. It would take me from an open buffer that is my full screen to my "full ide" in one key bind.

You can define it on your own by map_callback with function. Personally, I don't tend to define more keymaps for nvimdots.

@greggh
Copy link

greggh commented Jan 14, 2025

I would love it if the quickfix list went down to the bottom just like the toggleterm and help properly.

It has already configured. Do you mean Trouble project_diagnostics window?

You're right. For some reason it got messed up on my end where the quick fix list was coming up as half the screen instead of just at the bottom. But I think that was my fault now. Just tested again and its working fine.

@ayamir ayamir merged commit d7666c1 into main Jan 15, 2025
4 checks passed
@ayamir ayamir deleted the feat/better-window-layout branch January 15, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Edgy.nvim to put Trouble and other things in a sidebar, and forced bottom.
2 participants