You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
Sniffs (remember to share them with the open source community!)
Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found
Tests Performed:
This PR has been:
Tested in-game by the author.
Tested in-game by other community members/someone else other than the author/has been live on production servers.
This pull request requires further testing and may have edge cases to be tested.
How to Test the Changes:
This PR implements a change to the core loot system to fix an issue related to quest-based loot eligibility. The change ensures that only players who accept and own the associated quest can roll and receive specific loot items, such as "Shadowfrost Shard" or "Acidic Blood", while players without the associated quest are unable to participate in looting these items. The change ensures that the loot system works more accurately across groups with different quest states.
[x ] This pull request can be tested by following the reproduction steps provided in the linked issue
This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
Go to ICC and defeat the Bosses Rotface's and Festergut's - 25N and 25HC
Check if the Loot is appearing normally for those who have the quest 24545
Known Issues and TODO List:
[ ]
[ ]
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.
Tested in 25NH with 3 characters. Two character had the quest. One didn't.
The character that didn't accept the quest wasn't able to roll for either the Saronite or Acidic Blood (I tested both of them)
The characters with the quest could roll and the usual system worked fine.
EricksOliveira
changed the title
fix(Core/Loot): Acidic Blood and Shadowfrost Shard
fix(Core/Loot): Core modification to fix loot system behavior related to quest-based item eligibility
Jan 4, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
CORE
Helias
changed the title
Exitare
added
Ready to be Reviewed
Tested
EricksOliveira
changed the title
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
This PR implements a change to the core loot system to fix an issue related to quest-based loot eligibility. The change ensures that only players who accept and own the associated quest can roll and receive specific loot items, such as "Shadowfrost Shard" or "Acidic Blood", while players without the associated quest are unable to participate in looting these items. The change ensures that the loot system works more accurately across groups with different quest states.
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.