fix(DB/Quest) - Fortunate Misunderstandings

[EricksOliveira]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• [x ] Database (SAI, creatures, etc).

Issues Addressed:

• Closes Fortunate Misunderstandings" Quest Completion Bug in Sholazar Basin #19295

SOURCE:

The changes have been validated through:

• [x ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• [x ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• [x ] Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

After the NPC Injured Rainspeaker Oracle = 28217 is escorted to the Rainspeaker Canopy Camp. Complete the Quest Fortunate Misunderstandings = 12570.

• [x ] This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .quest add 12570
2. Speak to Injured Rainspeaker Oracle = 28217
3. Escort the Injured Rainspeaker Oracle to the Rainspeaker Canopy Camp
4. Please note that at the end of the route the quest must be completed.
5. You must have completed quest ID: 12540 to unlock the conversation with the NPC.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[TheSCREWEDSoftware]

Newline at the end in the SQL. Fix your issue description and tells us a little more what are you doing with this fix.

[Exitare]

Hi,
i tried to test your fix but couldnt.
Steps.

1. .go c 101028
2. .quest add 12570
3. talked to the creature, but cant interact with it, nor can i escort it.

Could you please refine the steps on how to test it? Please also fix your PR matkdown.

[EricksOliveira]

Olá, tentei testar sua correção, mas não consegui. Passos.

1. .vá c 101028
2. .quest adicionar 12570
3. falei com a criatura, mas não consigo interagir com ela, nem posso escoltá-la.

Você poderia refinar os passos sobre como testá-lo? Por favor, também conserte seu PR matkdown.

It's a chain quest. So you need to do this quest ID: 12540 first. Only then will the quest be released and you can talk to the NPC.

[TheSCREWEDSoftware]

Tested and works but I'm not sure don't think we are doing it correctly. To my understand upon completing of the escort that npc (which was stored from the previous quest if i read it correctly). He should use the "spell" that completes the quest and allows you to deliver it.

For anyone testing like @Exitare which was confused and I can't blame him for the lack of proper steps to test.

• Create a char with any race
• .level 79 // You will be 80
• .go c i 28217 // NPC: Injured Rainspeaker Oracle
• .quest add 12540 // Quest: Just Following Orders
• Talk to the NPC Injured Rainspeaker Oracle (there more than one around, you only need to talk to one).
• A crocklisk will appear, kill it (quest should be completed and ready to deliver), and a npc appears talks shit and goes away.
• Deliver the quest you just completed Just Following Orders and now you will be able to grab the next one Fortunate Misunderstandings.
• Talk to the Talk to the NPC Injured Rainspeaker Oracle after grabbing the quest and you have to talk to him and follow him. (and yes his path is broken he requires sniffs). And you follow him up kill anything that tries to attack him.
• Get to the village, a enemy appear, the rainspeaker says a quote, completes the quest and you can deliver it.

[EricksOliveira]

Yes, you are correct. The correct thing was for the NPC to cast a Spell. However, for some reason I couldn't identify this problem. I did some tests and the Spell needs to be Clicked twice to work, which is why the Cast doesn't work. I don't know if that's the reason. So I modified the code so that at the end of the escort the Quest is completed, just like many others that work the same way. The only difference is that the NPC no longer casts and completes the Quest normally at the end of the escort.

[Kitzunu]

This is a hack. You have to fix the spell, which can be done in a spellscript with FilterTargets