Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split item filtering into separate source file #75

Merged
merged 8 commits into from
May 9, 2024

Conversation

dedmen
Copy link

@dedmen dedmen commented Nov 3, 2023

Addition onto #57
Merge current Master branch (would be better to do that into rework branch first)
Split the item indexing/filtering out into separate files, and fix the broken conditions introduced in #57

Actual changes in eab81cf

I compared item counts from before(non-broken master branch)/after to confirm they match

AuctionHouseBot:
5957 disabled items
Loaded 5 grey trade goods
Loaded 471 white trade goods
Loaded 58 green trade goods
Loaded 26 blue trade goods
Loaded 3 purple trade goods
Loaded 1 orange trade goods
Loaded 0 yellow trade goods
Loaded 1633 grey items
Loaded 2771 white items
Loaded 5520 green items
Loaded 1645 blue items
Loaded 809 purple items
Loaded 0 orange items
Loaded 1 yellow items

With Rogue items disabled (Because I modified the way disabled class items are filtered)

AuctionHouseBot:
5957 disabled items
Loaded 5 grey trade goods
Loaded 471 white trade goods
Loaded 58 green trade goods
Loaded 26 blue trade goods
Loaded 3 purple trade goods
Loaded 1 orange trade goods
Loaded 0 yellow trade goods
Loaded 1628 grey items
Loaded 2699 white items
Loaded 5520 green items
Loaded 1645 blue items
Loaded 807 purple items
Loaded 0 orange items
Loaded 1 yellow items

All still matches

@dedmen dedmen changed the title chore: switch to reusable module workflow (#58) Split item filtering into separate source file Nov 3, 2023
@Helias
Copy link
Member

Helias commented Nov 4, 2023

thanks for your PR!
Build is failing, check the errors in the pipeline please

@dedmen
Copy link
Author

dedmen commented Nov 5, 2023

Buildfail is actually something from rework branch
AuctionHouseBot.h:3:1: fatal error: '/*' within block comment [-Wcomment]

Also I put the wrong license header, trinitycore one instead of AC

@dedmen
Copy link
Author

dedmen commented Nov 6, 2023

Are you okey with my file naming? The other files all prefix "AuctionHouseBot", but I don't think there is actually a technical reason to do that?
I would prefer shorter names, we already know this is AuctionHouseBot because it's in "mod-ah-bot/src" folder

@dedmen
Copy link
Author

dedmen commented May 9, 2024

This is still waiting, any update?

I would like to make more contributions but its very hard to handle all the conflicts.

@Helias Helias merged commit 739ae72 into azerothcore:rework-1 May 9, 2024
@Helias
Copy link
Member

Helias commented May 9, 2024

merged, thanks!

@dedmen dedmen deleted the ReworkSplitIndex branch May 10, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants