-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split item filtering into separate source file #75
Conversation
thanks for your PR! |
Buildfail is actually something from rework branch Also I put the wrong license header, trinitycore one instead of AC |
Are you okey with my file naming? The other files all prefix "AuctionHouseBot", but I don't think there is actually a technical reason to do that? |
This is still waiting, any update? I would like to make more contributions but its very hard to handle all the conflicts. |
merged, thanks! |
Addition onto #57
Merge current Master branch (would be better to do that into rework branch first)
Split the item indexing/filtering out into separate files, and fix the broken conditions introduced in #57
Actual changes in eab81cf
I compared item counts from before(non-broken master branch)/after to confirm they match
With Rogue items disabled (Because I modified the way disabled class items are filtered)
All still matches